Annoyingly the Xbox Series X controller appears to have the standard arrangement for battery compartments with the springs making contact with the negative terminal of the battery, however, it’s only the case for one of the batteries. The other contact is reversed and the positive terminal contacts the spring.
I feel dumb because I have to look at the printed orientation every time.
There were enough idiots that didn't know how to plug in a USB cord that they redesigned that, people not being able to understand batteries are not surprising really.